-
Notifications
You must be signed in to change notification settings - Fork 28
Edit onboarding flow to rewite image names in helm chart #3357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for replicated-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for replicated-docs-upgrade ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
||
For more information, see [Connect to an External Registry](/vendor/packaging-private-images). | ||
:::note | ||
You will add a custom domain for the proxy registry as part of [Task 9: Alias Replicated Endpoints with Your Own Domains](#task-9-alias-replicated-endpoints-with-your-own-domains). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a little weird to do this later, because then you have to come back and amend these edits again. but that's okay if that's what makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah that's a good point...For this pass, I'll probably just want to confirm that the adding custom domains task actually does correctly remind people to go back and edit these.
I'll want to give a little more time to considering if custom domains is perhaps something that should come earlier in the onboarding flow...onboarding is one of those things where it can be hard to pick a "step one" since there are several possible entry points
Co-authored-by: Alex Parker <7272359+ajp-io@users.noreply.github.com>
Updates the Replicated Onboarding flow to reflect the new proxy registry process (as in, telling users to edit image names in their helm values rather than using the HelmChart custom resource):
They’ll then add the SDK and package their chart before adding it to a new release.
Related to: #3209